Repository navigation
Conversation
So it plays nicely with `at_exit` (especially of `simplecov`). While finishing forked processes with `exit!` is a good idea (to ensure killing child processes), master process doesn't really needs to be forcely killed. http://ruby-doc.org/core-2.3.0/Kernel.html#method-i-exit See https://github.com/colszowka/simplecov/blob/v0.11.2/lib/simplecov/defaults.rb#L52 for how `simplecov` creates result at very last of the test suite.
|
This seems reasonable, however I think there can be some issue with minitest autorun's usage of at_exit, which would cause tests to run again after test-queue finishes. |
|
Would it be possible for you to use the summarize hook to invoke SimpleCov manually? |
|
@tmm1 thx for response!
yeah after I wrote this PR I thought it through, and came up with https://gist.github.com/konk303/0f32019c7fc0d1119b5936888ecb9884/revisions Looks pretty clean and reasonable 😃 Although I still feel killing master with non-bang-exit is a descent way, pls feel free to close this. (Maybe I should be writing wiki on |
So it plays nicely with
at_exit(especially ofsimplecov).While finishing forked processes with
exit!is a safeidea (to ensure killing child processes), master process doesn't really
needs to be forcely killed.
refs #35